-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-worker-memory flaky on Windows CI #25042
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
windows
Issues and PRs related to the Windows platform.
test
Issues and PRs related to the tests.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
fast-track
PRs that do not need to wait for 48 hours to land.
worker
Issues and PRs related to Worker support.
labels
Dec 14, 2018
cjihrig
approved these changes
Dec 14, 2018
gireeshpunathil
approved these changes
Dec 14, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19526/ |
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19534/ ✔️ |
Landed in 87006be |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 14, 2018
Refs: nodejs#23277 PR-URL: nodejs#25042 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
Refs: #23277 PR-URL: #25042 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Dec 24, 2018
Refs: nodejs#23277 PR-URL: nodejs#25042 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Refs: nodejs#23277 PR-URL: nodejs#25042 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Refs: #23277 PR-URL: #25042 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
Refs: #23277 PR-URL: #25042 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Refs: #23277 PR-URL: #25042 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
test
Issues and PRs related to the tests.
windows
Issues and PRs related to the Windows platform.
worker
Issues and PRs related to Worker support.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collaborators, please 👍 to fast-track.
Refs: #23277
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes